Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated security error for OngoingFork #565

Closed
gregdhill opened this issue Apr 8, 2022 · 1 comment
Closed

Add dedicated security error for OngoingFork #565

gregdhill opened this issue Apr 8, 2022 · 1 comment

Comments

@gregdhill
Copy link
Member

gregdhill commented Apr 8, 2022

Transaction verification is disabled if we have an OngoingFork with more confirmations + the security parameter than the main chain (see here). This is not reflected in the security module and thus our client-side code is unable to determine if it is valid to execute a payment. We should reflect this possible downtime in the security pallet to also avoid unintended lapses in the expiry periods.

@gregdhill
Copy link
Member Author

We no longer use the global security errors, see the (now closed) linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant