Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(democracy): fast-track referendum #653

Merged
merged 2 commits into from Jun 27, 2022
Merged

feat(democracy): fast-track referendum #653

merged 2 commits into from Jun 27, 2022

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Jun 21, 2022 •
edited

  • Adds fast_track_referendum extrinsic, callable by the technical committee
  • Adds FastTrackReferendum event
  • Although renaming the fast_track extrinsic to fast_track_proposal makes sense given the addition, it's not changed to preserve backwards-compatibility

gregdhill
gregdhill reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@gregdhill gregdhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace, thanks @savudani8! Before we merge can you check with OpenSquare if these changes will affect their UI?

@nud3l
Copy link
Member

nud3l commented Jun 22, 2022

Is this going to affect polkadot.js as well? I usually use https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fapi.interlay.io%2Fparachain#/techcomm to fast-track proposals

@sander2 sander2 changed the title feat(democracy): fast-track referendum [BREAKING] feat(democracy): fast-track referendum Jun 22, 2022
@sander2
Copy link
Member

sander2 commented Jun 22, 2022

LGTM but it's probably easier to keep the fast_track naming unchanged to prevent breaking subsquare and polkadot

@daniel-savu
Copy link
Contributor Author

daniel-savu commented Jun 23, 2022 •
edited

Will break polkadot-js indeed, found the line: https://github.com/polkadot-js/apps/blob/154128ab745e41ffb7a96d0f527a17c48ff5cf84/packages/page-democracy/src/Overview/Fasttrack.tsx#L76

Can't check openSquare's source. I'll revert the name change.

@daniel-savu daniel-savu force-pushed the feature/referendum-fast-track branch from db39322 to f2fd8ae Compare June 23, 2022 09:47
@daniel-savu daniel-savu changed the title [BREAKING] feat(democracy): fast-track referendum feat(democracy): fast-track referendum Jun 23, 2022
@nud3l nud3l merged commit ee41fef into interlay:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sander2 sander2 sander2 approved these changes

@nud3l nud3l nud3l approved these changes

@gregdhill gregdhill Awaiting requested review from gregdhill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daniel-savu @nud3l @sander2 @gregdhill