New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vault): client release version #668
Merged
daniel-savu
merged 8 commits into
interlay:master
from
daniel-savu:feature/vault-release-version
Jul 25, 2022
Merged
feat(vault): client release version #668
daniel-savu
merged 8 commits into
interlay:master
from
daniel-savu:feature/vault-release-version
Jul 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nud3l
reviewed
Jul 8, 2022
3 tasks
gregdhill
requested changes
Jul 22, 2022
daniel-savu
force-pushed
the
feature/vault-release-version
branch
from
July 25, 2022 06:51
50da4f6
to
2c5710e
Compare
gregdhill
requested changes
Jul 25, 2022
sander2
approved these changes
Jul 25, 2022
gregdhill
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault Release Binary Info
This PR adds storage fields to act as the on-chain source of truth about the currently recommended vault version. It is part of the broader effort to develop a vault auto-updater (see #672 and interlay/interbtc-clients#310).
Adds two storage fields,
CurrentClientRelease
andPendingClientRelease
, and two corresponding eventsNotifyClientRelease
andApplyClientRelease
.PendingClientRelease
is meant to be batched alongside theparachainSystem.enactAuthorizedUpgrade
relay chain xcm call, shortly before a runtime upgraded is applied (about an hour); this allows the auto-updater software the time to download the next release binary and switch to it immediately after a runtime upgrade.When a runtime upgrade occurs, the client version stored in
PendingClientRelease
is migrated toCurrentClientRelease
.