refactor!: remove all Bitcoin parsing and use concrete types #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
refactor/remove-parsing
branch
3 times, most recently
from
cd81b85
to
9eb6283
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
refactor/remove-parsing
branch
from
9eb6283
to
7e7e260
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
nud3l
previously requested changes
Apr 12, 2023
There was a problem hiding this comment.
We need to re-run the script fetching current Bitcoin block headers and transactions to verify this change with the most recent blocks.
Also, I'd like to open a discussion if we should switch over to using https://github.com/rust-bitcoin/rust-bitcoin for our type needs.
sander2
reviewed
Apr 12, 2023
sander2
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
Closes #605
Open points:
hashfield fromBlockHeader?BoundedVecfor the scripts and witnesses?