feat: allow requester to call cancel_issue #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
feat/cancel-issue
branch
from
56b2f2f
to
053839e
Compare
sander2
reviewed
Aug 18, 2022
sander2
requested changes
Aug 30, 2022
gregdhill
force-pushed
the
feat/cancel-issue
branch
from
1f097e5
to
a1ab3fd
Compare
sander2
previously approved these changes
Sep 14, 2022
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/cancel-issue
branch
from
a1ab3fd
to
5dc001c
Compare
sander2
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
Allows the
requesterto callcancel_issueup until expiry but the closer to the deadline this is done the more griefing collateral will be slashed.