Allow user to set a custom logger #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
emschwartz
added a commit
that referenced
this pull request
Oct 16, 2015
Allow user to set a custom logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pathfind is just a module (not a whole application) it should not instantiate any services. Services generally can malfunction if multiple instances are created in the same process.
In the current version of
five-bells-demo, this causes a crash because multiple instances of the log service in five-bells-shared are trying to be instantiated. (Issue will not appear when usingnpm link.)By making the logging pluggable, this module also no longer requires five-bells-shared.