fix: ledger/prefix asserts; getInfo().connectors #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sentientwaffle
commented
Sep 20, 2016
sentientwaffle
commented
- Fix ledger/prefix assertions: The account field refers to the local source account that the transfer originated from. (see https://github.com/interledger/rfcs/blob/master/0004-ledger-plugin-interface/0004-ledger-plugin-interface.md#incomingtransfer)
- getInfo().connectors (see https://github.com/interledger/rfcs/blob/master/0004-ledger-plugin-interface/0004-ledger-plugin-interface.md#class-connectorinfo)
- Disallow transfers with amount=0
sharafian
reviewed
Sep 21, 2016
| @@ -53,13 +54,13 @@ describe('Plugin transfers (universal)', function () { | |||
|
|
|||
| this.pluginA.once('outgoing_fulfill', (transfer) => { | |||
| assert.equal(transfer.id, id) | |||
| assert.equal(transfer.ledger, 'test.nerd.') | |||
| assert.equal(transfer.ledger, this.pluginA.prefix) | |||
There was a problem hiding this comment.
How come this is .prefix and not .getPrefix()?
There was a problem hiding this comment.
Oops, you're right
sharafian
reviewed
Sep 21, 2016
| @@ -41,31 +41,15 @@ describe('Plugin transfers (optimistic)', function () { | |||
| assert.isFunction(this.pluginA.send) | |||
| }) | |||
|
|
|||
| it('should send an optimistic transfer with 0 amount', function (done) { | |||
There was a problem hiding this comment.
https://github.com/interledger/rfcs/blob/master/0004-ledger-plugin-interface/0004-ledger-plugin-interface.md#ledger-transfers says that "all plugins MUST implement 0-amount transfers." It does seem impractical for now though. maybe skip this instead of deleting it?
There was a problem hiding this comment.
0-amount transfers are going to be removed in favor of sendMessage() (see interledger/rfcs#96).
|
LGTM |
* Fix ledger/prefix assertions: The account field refers to the local source account that the transfer originated from. (see https://github.com/interledger/rfcs/blob/master/0004-ledger-plugin-interface/0004-ledger-plugin-interface.md#incomingtransfer) * getInfo().connectors (see https://github.com/interledger/rfcs/blob/master/0004-ledger-plugin-interface/0004-ledger-plugin-interface.md#class-connectorinfo) * Disallow transfers with amount=0
sentientwaffle
force-pushed
the
dj-rfc-sync
branch
from
f3fc8a6
to
3020817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.