Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to cell_once instead of lazy_static #588

Closed
gakonst opened this issue Jan 18, 2020 · 0 comments · Fixed by #618
Closed

Migrate to cell_once instead of lazy_static #588

gakonst opened this issue Jan 18, 2020 · 0 comments · Fixed by #618
Assignees
Labels
dependencies enhancement good-first-issue v1.0 Issues which need to be handled for a v1.0 release

Comments

@gakonst
Copy link
Member

gakonst commented Jan 18, 2020

@bstrie wrote:

For about a year now the Rust constant-evaluation pipeline has been robust enough that lazy_static is entirely replaceable by the once_cell crate, which provides a macro-free way of doing what lazy_static once did.
(furthermore, the once_cell stuff is being considered for inclusion in std: rust-lang/rfcs#2788)

This should be easy and fairly straightforward.

The PR should also disable the filter for lazy static in our cargo audit call: https://github.com/interledger-rs/interledger-rs/blob/master/.circleci/config.yml#L50

@gakonst gakonst added v1.0 Issues which need to be handled for a v1.0 release enhancement good-first-issue dependencies labels Jan 18, 2020
@gakonst gakonst assigned gakonst and unassigned dora-gt Jan 31, 2020
@bstrie bstrie assigned bstrie and unassigned gakonst Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement good-first-issue v1.0 Issues which need to be handled for a v1.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants