Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate panics from tokio #302

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Propagate panics from tokio #302

merged 2 commits into from
Sep 16, 2019

Conversation

emschwartz
Copy link
Member

Resolves #300

gakonst
gakonst approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a nitpicky comment

crates/interledger/src/node.rs Outdated Show resolved Hide resolved
@emschwartz emschwartz force-pushed the es-panics branch 2 times, most recently from 4015fd3 to 39be1b7 Compare September 16, 2019 06:30
@emschwartz emschwartz merged commit 1fb465e into master Sep 16, 2019
@emschwartz emschwartz deleted the es-panics branch September 16, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@bstrie bstrie Awaiting requested review from bstrie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure tokio to kill the server when a worker panics
2 participants
@emschwartz @gakonst