Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all FOO_PUBLIC_* config options #133

Open
3 tasks
justmoon opened this issue Apr 28, 2016 · 0 comments
Open
3 tasks

Consolidate all FOO_PUBLIC_* config options #133

justmoon opened this issue Apr 28, 2016 · 0 comments

Comments

@justmoon
Copy link
Contributor

justmoon commented Apr 28, 2016 •
edited by gip
Loading

Currently red.ilpdemo.org ledger is configured with:

LEDGER_HOSTNAME=red.ilpdemo.org LEDGER_PUBLIC_PORT=443 LEDGER_PUBLIC_PATH=ledger LEDGER_PUBLIC_HTTPS=true

It seems like it would be much simpler to replace all that with:

LEDGER_PUBLIC_URI=https://red.ilpdemo.org/ledger

  • Old config options should still be accepted
  • Old config options should emit a deprecation warning
  • Notify component owners to update their docs/readmes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justmoon