Fix build on Rust 1.45.0 and up #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
niklaslong
force-pushed
the
u64-undefined-behavior
branch
5 times, most recently
from
2b61c7c
to
3970583
Compare
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
niklaslong
force-pushed
the
u64-undefined-behavior
branch
5 times, most recently
from
9873a54
to
061d58a
Compare
niklaslong
changed the title
Co-authored-by: Belsy Yuen <belsy@equilibrium.co> Signed-off-by: Niklas Long <niklas@equilibrium.co>
niklaslong
force-pushed
the
u64-undefined-behavior
branch
from
061d58a
to
0fce796
Compare
ljedrz
reviewed
Oct 5, 2020
ljedrz
reviewed
Oct 5, 2020
Signed-off-by: Niklas Long <niklas@equilibrium.co>
|
@ljedrz CI fails (no test is actually failing, might be because circleci is having some issues?) though it's green locally. I don't have the permissions to re-run the build on this. In addition to the fixes discussed, I've also fixed a new 1.47 release related clippy lint. |
Signed-off-by: Niklas Long <niklas@equilibrium.co>
niklaslong
force-pushed
the
u64-undefined-behavior
branch
from
9ddd1d3
to
85fcd11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the f64 to u64 conversion and associated bounds for the outgoing amount in the exchange rate calculation.
Included:
cargo update)asas a saturating conversion.12.18.4(the JS ilp-settlement-xrp package which used the ripple-binary-codec lib is no longer compatible with Node11x)account updateandaccount update-settingsFIXMEin CI config. All offending deps have been ignored (beyond the scope of this PR).net2has been replace withsocket2ininterledgercrates, though is still present intokio: RUSTSEC-2020-0016:net2crate has been deprecated; usesocket2instead tokio-rs/tokio#2677