Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Review code samples on home page #66

Closed
michielbdejong opened this issue Oct 2, 2017 · 7 comments
Closed

Review code samples on home page #66

michielbdejong opened this issue Oct 2, 2017 · 7 comments
Assignees

Comments

@michielbdejong
Copy link
Contributor

The code samples on the home page use import so they won't work in nodejs. I also can't see how they would work in the browser. When you click 'Try it out', you get pointed to ilp-kit, and we know from the questions people ask in gitter, that the ilp-kit API is what most developers focus on.

As we start merging the tutorials, we should probably remove the code samples from the interledger.org homepage, and point to the Letter Shop tutorial instead?

@michielbdejong michielbdejong changed the title Review code samples on home page usable Review code samples on home page Oct 2, 2017
@michielbdejong
Copy link
Contributor Author

@adrianhopebailie what do you think? Shall I prepare a PR for that?

@bsteinlo
Copy link
Contributor

bsteinlo commented Oct 2, 2017

@michielbdejong could I request that you post a preview of this on a forked gh-pages so I can visually check it out? We made the visual on the right correspond to the height and everything of the code samples, so I just want to make sure it doesn't break. Thanks!

@michielbdejong
Copy link
Contributor Author

Maybe we can keep the teaser snippets on there, but when people click 'Try it out' we then send them to https://interledger.org/tutorials/letter-shop?

@emschwartz
Copy link
Member

I agree we should update the snippets sometime in the near future. Maybe we should wait until we figure out the ilp-plugin thing and possibly @justmoon's ILP Quickstart thing. Once the tutorials are ready to go I think it would be a good idea to link them from there

@bsteinlo
Copy link
Contributor

bsteinlo commented Oct 4, 2017 via email

@adrianhopebailie
Copy link
Collaborator

+1

@michielbdejong
Copy link
Contributor Author

Done, see https://interledger.org/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants