Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple open payments guide #59
Simple open payments guide #59
Changes from 2 commits
07f991e
b17a609
909e08c
bf1e93a
4241942
810fa3a
d9acc8d
e5e134a
dc0e4ff
660caec
bde7b2d
6b3f6fa
e975943
409954f
9475d67
bae26d3
dae99d8
5d77632
658d52c
af007e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "receiving bank" can be removed here, given the paragraph talks about the challenge of moving money between a sending bank directly to a mobile money provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkurapov my idea here was that the fundraising app did a direct integration with their bank (where they'd like to receive funds). Now the sender has a bank, that's fine because bank A can probably talk to bank B. But if the sender has a mobile money account or digital wallet we may have issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoblersTune makes sense, in that case, maybe we can just rename from "receiving" to "merchant" bank maybe (or "fundraisers" bank), and then "customer" bank? To remove any confusion from sending/receiving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"But it’s also advantageous for you because you don't need to share sensitive information with online applications"
This is just a thought I had (especially knowing the banking context in Canada/North America), but we could also mention that without any API standards, some third-party apps like budget trackers rely on web-scraping to actually connect your bank accounts, meaning they end up knowing your banking login details too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move that to the top to be an actual TLDR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we change the name to "Key Takeaways" instead.
My reluctance with moving it to the top is that I want to create a gentle path through the post that encourages an incremental introduction to the concepts. I worry it's kind off putting to put the summary at the top. People who are less technical might feel like this article is pitched over their heads. But by the time they reach the bottom they should understand all of this and it just re-captures the main points to give a simple summary of what OP is.
What do you think?