fix: dont base64 encode rejection reasons #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.97% (diff: 100%)@@ master #36 diff @@
==========================================
Files 6 6
Lines 297 299 +2
Methods 38 38
Messages 0 0
Branches 68 69 +1
==========================================
+ Hits 273 275 +2
Misses 24 24
Partials 0 0
|
| @@ -536,7 +536,9 @@ class FiveBellsLedger extends EventEmitter2 { | |||
| relatedResources.cancellation_condition_fulfillment) | |||
| } else if (fiveBellsTransfer.state === 'rejected') { | |||
| const rejectedCredit = find(fiveBellsTransfer.credits, 'rejected') | |||
| const rejectionMessage = rejectedCredit ? rejectedCredit.rejection_message : 'transfer timed out.' | |||
| const rejectionMessage = rejectedCredit | |||
| ? new Buffer(rejectedCredit.rejection_message, 'base64').toString() | |||
There was a problem hiding this comment.
You should use Buffer.from (see https://nodejs.org/api/buffer.html#buffer_buffer_from_buffer_alloc_and_buffer_allocunsafe)
There was a problem hiding this comment.
That causes the FTs to fail when run against older versions of node.
There was a problem hiding this comment.
Hmm. I think not using it though would expose the DoS vulnerability that caused that switch in the first place. What if I set the rejection_message to 10000000000000?
There was a problem hiding this comment.
Ok, so we need to run the circleci tests with node 6, and then use Buffer.from.
There was a problem hiding this comment.
New issue: interledgerjs/five-bells-integration-test#39
This was referenced Sep 6, 2016
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.