feat: DuplicatePeer error #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
github-actions
bot
added
type: tests
mkurapov
requested review from
BlairCurrey,
sabineschaller,
njlie and
raducristianpopa
BlairCurrey
reviewed
Sep 13, 2023
BlairCurrey
previously approved these changes
Sep 13, 2023
packages/backend/src/peer/errors.ts
Outdated
| @@ -24,6 +26,7 @@ export const errorToMessage: { | |||
| [key in PeerError]: string | |||
| } = { | |||
| [PeerError.DuplicateIncomingToken]: 'duplicate incoming token', | |||
| [PeerError.DuplicatePeer]: 'duplicate peer', | |||
There was a problem hiding this comment.
Would it be better to provide a more specific error message rather than simply "Duplicate peer"?
There was a problem hiding this comment.
Updated to be more specific
sabineschaller
approved these changes
Sep 13, 2023
raducristianpopa
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
While building out the auto-peering service, I noticed that it didn't really make sense to allow creating a Peer with the same combination of
staticIlpAddressandassetId(this would mean a duplicate peering relationship). This adds a unique constraint for these two columns in the DB.Related to #1761
Checklist
fixes #number