chore: add logging, outgoing payment service changes #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
changed the title
mkurapov
commented
Feb 16, 2024
| return payment | ||
| } | ||
|
|
||
| function validateSentAmount( |
There was a problem hiding this comment.
standardize the error here
mkurapov
commented
Feb 16, 2024
| @@ -276,18 +278,14 @@ async function validateGrant( | |||
| return false | |||
| } | |||
|
|
|||
| // Lock grant | |||
| // TODO: update to use objection once it supports forNoKeyUpdate | |||
There was a problem hiding this comment.
using objection now
mkurapov
commented
Feb 16, 2024
| @@ -3,7 +3,12 @@ import { Logger } from 'pino' | |||
| import { ReadContext, CreateContext, ListContext } from '../../../app' | |||
There was a problem hiding this comment.
just logging & more gracefully handling 500 errors
mkurapov
commented
Feb 16, 2024
Comment on lines
-167
to
-170
| { | ||
| ...deps, | ||
| knex: trx | ||
| }, |
There was a problem hiding this comment.
explicitly passing in trx now instead of "mutating" deps.knex
mkurapov
commented
Feb 16, 2024
| ) | ||
| if (totalSent === undefined) { | ||
| throw new Error() |
There was a problem hiding this comment.
we have a few of these throw new Error(), so trying to get rid of them slowly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Some minor refactoring around outgoing payments: standardising logging, updating functions & adding tests.
Context
Mostly to improve our logging & error handling + checking off a TODO item in the code.
Checklist
fixes #number