test(backend): add test for unknown destination account #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BlairCurrey
reviewed
Mar 19, 2024
Comment on lines
+144
to
+146
| await expect(middleware(ctx, next)).rejects.toThrow( | ||
| 'unknown destination account' | ||
| ) |
There was a problem hiding this comment.
The task stated we should check for an UnreachableError specifically. I wondered if that was incidental or a core part of the task to ensure we're surfacing errors from the ilp spec or something? Probably couldn't hurt to include either way I guess.
await expect(middleware(ctx, next)).rejects.toThrow(
Errors.UnreachableError
)
BlairCurrey
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
fixes #974
Checklist
fixes #number