feat(backend): support single phase transfer in connector #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: backend
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
reviewed
Mar 22, 2024
| @@ -75,15 +75,13 @@ export function createBalanceMiddleware(): ILPMiddleware { | |||
|
|
|||
| if (state.streamDestination) { | |||
| await next() | |||
| if (response.fulfill) await createTransfer() | |||
There was a problem hiding this comment.
can we have a test for the single phase transfer? (we can at least probably assert that services.accounting.createTransfer was called without the timeout set)
packages/backend/src/payment-method/ilp/connector/core/middleware/balance.ts
Outdated
Show resolved
Hide resolved
mkurapov
reviewed
Mar 22, 2024
...ges/backend/src/payment-method/ilp/connector/core/test/middleware/balance-middleware.test.ts
Outdated
Show resolved
Hide resolved
…ddleware/balance-middleware.test.ts Co-authored-by: Max Kurapov <max@interledger.org>
mkurapov
approved these changes
Mar 22, 2024
mkurapov
added a commit
that referenced
this pull request
Apr 3, 2024
)" This reverts commit 81f8a05.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
fixes #1166
Checklist
fixes #number