Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exceptions): add message to exceptions that are missing message #2623

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix(exceptions): add message to exceptions that are missing message #2623

merged 2 commits into from
Apr 2, 2024

Conversation

golobitch
Copy link
Collaborator

Changes proposed in this pull request

  • Add error messages to Error exceptions that are without messages

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@golobitch golobitch self-assigned this Mar 30, 2024
@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Mar 30, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 30, 2024 •
edited

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 93c7ee7
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/660871d340231b0009675f13

sabineschaller
sabineschaller approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@sabineschaller sabineschaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you greped all of them and decided that the one remaining in the tests does not need a message ;-).
Thank you!

@sabineschaller sabineschaller merged commit 88ae1d4 into main Apr 2, 2024
23 checks passed
@sabineschaller sabineschaller deleted the feature/2579-error-msgs branch April 2, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabineschaller sabineschaller sabineschaller approved these changes

Assignees

@golobitch golobitch

Labels
pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all errors with missing messages (throw new Error())
3 participants
@golobitch @sabineschaller @tadejgolobic