Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autopeering - use localtunnel #2633

Merged
merged 6 commits into from Apr 11, 2024
Merged

fix: autopeering - use localtunnel #2633

merged 6 commits into from Apr 11, 2024

Conversation

sabineschaller
Copy link
Member

@sabineschaller sabineschaller commented Apr 4, 2024

Changes proposed in this pull request

I only swap out tunnelmole and now use localtunnel. The additional interaction is only required when accessing the localtunnel url through the browser. Hence, our API requests work fine.
Right now, the localtunnel "login" screen is shown when going through the consent flow. We could get around even that when we make the Rafiki.money user the sender and the local user the receiver. However, since Rafiki.money is not on the latest version of Rafiki, the polling interaction flow does not work yet.

Context

Even though it's not the same, it

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@github-actions github-actions bot added type: localenv Local playground pkg: documentation Changes in the documentation package. type: documentation Improvements or additions to documentation labels Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 59f8ad4
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6617a2d93ed2730008638886
😎 Deploy Preview https://deploy-preview-2633--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sabineschaller sabineschaller requested review from mkurapov and dragosp1011 and removed request for melissahenderson and hajjimo April 4, 2024 11:50
dragosp1011
dragosp1011 previously approved these changes Apr 4, 2024
@mkurapov
Copy link
Contributor

mkurapov commented Apr 5, 2024

I was able to send a payment from local env -> rafiki.money, but like you mention in the description, not the other way around.
However, do you think it would be better for rafiki.money to properly use the redirect step? that would seem to be a better experience than getting a blank page with "200 - Accepted" on it

@mkurapov
Copy link
Contributor

mkurapov commented Apr 5, 2024

My first time running this I got pretty aggressive auto-generated URLs:
Screenshot 2024-04-05 at 11 04 39

@sabineschaller
Copy link
Member Author

I was able to send a payment from local env -> rafiki.money, but like you mention in the description, not the other way around.
However, do you think it would be better for rafiki.money to properly use the redirect step? that would seem to be a better experience than getting a blank page with "200 - Accepted" on it

I'm not sure I follow

@mkurapov
Copy link
Contributor

mkurapov commented Apr 8, 2024

@sabineschaller
Sorry, not clear wording

When we are approving the grant request in rafiki.money, I think it would be better to use the grant initiation flow with the finish object (meaning, with interact_ref), since then we can get redirected to a proper page in rafiki.money (with finish.uri), instead of just seeing a blank html page with "Accepted 200".

@sabineschaller
Copy link
Member Author

@mkurapov

When we are approving the grant request in rafiki.money, I think it would be better to use the grant initiation flow with the finish object (meaning, with interact_ref), since then we can get redirected to a proper page in rafiki.money (with finish.uri), instead of just seeing a blank html page with "Accepted 200".

But what would that page be?

@mkurapov
Copy link
Contributor

@sabineschaller yeah I think I confused myself there 😅 , this is from bruno

@sabineschaller sabineschaller merged commit 3543fdf into main Apr 11, 2024
30 checks passed
@sabineschaller sabineschaller deleted the s2-localtunnel branch April 11, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: documentation Changes in the documentation package. type: documentation Improvements or additions to documentation type: localenv Local playground
Projects
None yet
3 participants