feat(backend): SPSPRouteError #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mkurapov
commented
May 7, 2024
| @@ -24,11 +37,20 @@ const spspMiddleware = async ( | |||
| ): Promise<void> => { | |||
| // Fall back to legacy protocols if client doesn't support Open Payments. | |||
| if (ctx.accepts('application/spsp4+json')) { | |||
| const receiver = ctx.walletAddress ?? ctx.incomingPayment | |||
There was a problem hiding this comment.
ctx.incomingPayment was a leftover thing from when we had the "connection" resource in Open Payments. does not apply anymore
mkurapov
commented
May 7, 2024
| const walletAddressService = await ctx.container.use('walletAddressService') | ||
|
|
||
| const walletAddress = await walletAddressService.getByUrl( | ||
| ctx.walletAddressUrl |
There was a problem hiding this comment.
Using ctx.walletAddressUrl instead of ctx.walletAddress as part of a larger refactor to remove the wallet address middleware altogether, see #2708
mkurapov
force-pushed
the
1905/mk/spsp-errors
branch
2 times, most recently
from
9edbd82
to
6cf1e7f
Compare
mkurapov
force-pushed
the
1905/mk/spsp-errors
branch
from
6cf1e7f
to
b0b6e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
SPSPRouteErrorinstead of directly callingctx.throw. This is then handled like any error thrown in the Open Payments routes/middlewareContext
Related to #1905
Checklist
fixes #number