feat(auth): secure admin api with hmac signatures #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: source
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
njlie
force-pushed
the
nl/2704/auth-admin-api-security
branch
from
3127c8b
to
b0aba23
Compare
mkurapov
reviewed
May 8, 2024
golobitch
reviewed
May 10, 2024
njlie
force-pushed
the
nl/2704/auth-admin-api-security
branch
from
7ea0902
to
5bd359b
Compare
BlairCurrey
reviewed
May 21, 2024
BlairCurrey
reviewed
May 21, 2024
njlie
force-pushed
the
nl/2704/auth-admin-api-security
branch
from
f75f811
to
cc173b6
Compare
BlairCurrey
previously approved these changes
May 23, 2024
mkurapov
reviewed
May 24, 2024
packages/auth/src/shared/utils.ts
Outdated
|
|
||
| async function canApiSignatureBeProcessed( | ||
| signature: string, | ||
| ctx: Context, |
There was a problem hiding this comment.
it would be good to type this Context such that we get the types for the services like redis and logger.
| const key = `signature:${signature}` | ||
| const op = redis.multi() | ||
| op.set(key, signature) | ||
| op.expire(key, signature) |
There was a problem hiding this comment.
should the expiry take in a num as the second argument?
| }, | ||
| 'time differential' | ||
| ) | ||
| if (currentTime - signatureTime > ttlMilliseconds) return false |
There was a problem hiding this comment.
I think we should add a test for this as well
BlairCurrey
approved these changes
Jun 7, 2024
mkurapov
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Closes #2704.
Checklist
fixes #number