Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): add services for managing RS grants #693

Closed
wants to merge 3 commits into from

Conversation

wilsonianb
Copy link
Contributor

@wilsonianb wilsonianb commented Oct 25, 2022

Changes proposed in this pull request

  • add auth server and grant services to backend
  • export and fix auth types

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related labels Oct 25, 2022
@wilsonianb wilsonianb marked this pull request as ready for review October 26, 2022 00:34
@sabineschaller
Copy link
Member

add auth server and grant services to backend

Is this actually moving auth into backend? I don't want to merge the two. The auth server should be plugable.

@wilsonianb
Copy link
Contributor Author

wilsonianb commented Nov 3, 2022

Is this actually moving auth into backend?

No, this is adding tables and services to the backend to manage:

  • Open Payments auth servers (not including its own) at which it has grants to make client requests
  • its grants

@wilsonianb
Copy link
Contributor Author

If we want, this pr could wait for:

and then be updated to fully resolve:

(and import types from open-payments instead of auth)

@wilsonianb
Copy link
Contributor Author

Converting to draft for 👆

@wilsonianb wilsonianb marked this pull request as draft November 7, 2022 17:11
@wilsonianb
Copy link
Contributor Author

@wilsonianb wilsonianb closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants