Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add settlement engine RFC #536

Merged
merged 35 commits into from
Oct 20, 2019
Merged

docs: add settlement engine RFC #536

merged 35 commits into from
Oct 20, 2019

Commits on Jun 20, 2019

  1. docs: add settlement engine RFC

    @kincaidoneil
    kincaidoneil committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    4e742ae View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. fix: initial edit batch, accounting explanation

    @kincaidoneil
    kincaidoneil committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    5ea7edd View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. docs: flesh out bookkeeping and peer messaging 

    - numerous verbiage changes for clarity
- explain necessary guarantees for double-entry bookkeeping
- more explicit spec for use with ILP-over-HTTP
- rename transport/acc sys apis to "settlement engine callback api"
- rename API endpoints to match consensus/implementations
- remove confusing examples (more relevant for a tutorial)
- remove old idempotency section, new version is WIP
    @kincaidoneil
    kincaidoneil committed Aug 2, 2019
    5 Configuration menu
    Copy the full SHA
    4236171 View commit details
    Browse the repository at this point in the history

  2. docs: highlight settlement engine spec, hide LPIv2

    @kincaidoneil
    kincaidoneil committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    8ecad82 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. fix: more general asset/unit definitions 

    Co-Authored-By: David Fuelling <sappenin@gmail.com>
    @kincaidoneil @sappenin
    kincaidoneil and sappenin committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    536932d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ko-settlement-engine' of https://github.com/interledger… 

    …/rfcs into ko-settlement-engine
    @kincaidoneil
    kincaidoneil committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    036311a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. fix: misc edits, async settlement design 

    - fix: miscellaneous verbiage edits for clarity
- add section explaining rationale for async settlement design
- simpler expalantion for exchanging messages between SEs
- fix: no u64 limit to quantity
- add delete account endpoint
- fix anchor links to Quantity section
    @kincaidoneil
    kincaidoneil committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    2da9cbd View commit details
    Browse the repository at this point in the history

  2. fix: increment interledger arch draft

    @kincaidoneil
    kincaidoneil committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    579e27c View commit details
    Browse the repository at this point in the history

  3. fix: explain rationale to support different scales

    @kincaidoneil
    kincaidoneil committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    18f2eec View commit details
    Browse the repository at this point in the history

  4. fix: clarify asset amount not tied to denomination 

    Co-Authored-By: David Fuelling <sappenin@gmail.com>
    @kincaidoneil @sappenin
    kincaidoneil and sappenin committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    43cfa06 View commit details
    Browse the repository at this point in the history

  5. fix: clarify pre-payment, minor changes

    @kincaidoneil
    kincaidoneil committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    93e476c View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. fix: clarify account, improve settlement symmetry

    @kincaidoneil
    kincaidoneil committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    fa37819 View commit details
    Browse the repository at this point in the history

  2. fix: plural settlement engines 

    - add WIP of webhook API
    @kincaidoneil
    kincaidoneil committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    5b49313 View commit details
    Browse the repository at this point in the history

  3. docs: add idempotence behavior

    @kincaidoneil
    kincaidoneil committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    3a495b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. fix: no idempotence for sending messages

    @kincaidoneil
    kincaidoneil committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    b5d88d1 View commit details
    Browse the repository at this point in the history

  2. fix: minor edits

    @kincaidoneil
    kincaidoneil committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    f0349fc View commit details
    Browse the repository at this point in the history

  3. docs(settlement): clean up api docs, webhooks

    @kincaidoneil
    kincaidoneil committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    1497868 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. fix: clarify rounding to 0 behavior 

    Co-Authored-By: Evan Schwartz <evan.mark.schwartz@gmail.com>
    @kincaidoneil @emschwartz
    kincaidoneil and emschwartz committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    cca172f View commit details
    Browse the repository at this point in the history

  2. fix: minor edits, address comments

    @kincaidoneil
    kincaidoneil committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    61baa23 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. fix: simplify, address comments, add diagram

    @kincaidoneil
    kincaidoneil committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    69dd834 View commit details
    Browse the repository at this point in the history

  2. fix: update flow diagram for readability

    @kincaidoneil
    kincaidoneil committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    ace4c0c View commit details
    Browse the repository at this point in the history

  3. fix: smaller margins on flow diagram

    @kincaidoneil
    kincaidoneil committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    6aea82c View commit details
    Browse the repository at this point in the history

  4. fix: even smaller diagram margins

    @kincaidoneil
    kincaidoneil committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    ef8d974 View commit details
    Browse the repository at this point in the history

  5. fix: minor diagram edits

    @kincaidoneil
    kincaidoneil committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    b57c4b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. fix: apply suggestions 

    Co-Authored-By: David Fuelling <sappenin@gmail.com>
Co-Authored-By: Georgios Konstantopoulos <me@gakonst.com>
    @kincaidoneil @sappenin @gakonst
    3 people committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    3330782 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. fix: apply suggestion 

    Co-Authored-By: David Fuelling <sappenin@gmail.com>
    @kincaidoneil @sappenin
    kincaidoneil and sappenin committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    76c7176 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. fix: bring inline with existing implementations 

    - response codes are now 201 to conform to REST
- creating an account is a POST with an account ID in the body
- other misc changes per comments
    @kincaidoneil
    kincaidoneil committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    9d5e5cf View commit details
    Browse the repository at this point in the history

  2. fix: merge with remote changes

    @kincaidoneil
    kincaidoneil committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    ee6f48b View commit details
    Browse the repository at this point in the history

  3. fix: safer idempotency/retry behavior 

    - max retry interval is 1 hour
- servers may purge idempotency keys 24 hours after most recent request
- clients must retry indefinitely in response to 5xx, 409, and no response errors
- 4xx errors should have no retry
- remove min max on idempotency key length
- explain why retry behavior is specced
    @kincaidoneil
    kincaidoneil committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    07a2be9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. fix: apply suggestions 

    Co-Authored-By: pgarg-ripple <51800920+pgarg-ripple@users.noreply.github.com>
    @kincaidoneil @pgarg-ripple
    kincaidoneil and pgarg-ripple committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    a8a0426 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. docs(se): remove refunds, simplify, final edits

    @kincaidoneil
    kincaidoneil committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    79d6c19 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ko-settlement-engine

    @kincaidoneil
    kincaidoneil committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    c9f3a63 View commit details
    Browse the repository at this point in the history

  3. fix: add settlement engine link to website sidebar

    @kincaidoneil
    kincaidoneil committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    07cf997 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2019

  1. docs(se): minor edits

    @kincaidoneil
    kincaidoneil committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    c74b71a View commit details
    Browse the repository at this point in the history

  2. docs(se): fix create account json payload

    @kincaidoneil
    kincaidoneil committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    3a4b528 View commit details
    Browse the repository at this point in the history