-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Proposals": An improvement to the Interledger RFC Submission Process #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update how to contribute an RFC. * Add new folders for RFC organization. Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
Signed-off-by: sappenin <sappenin@gmail.com>
sappenin
requested review from
adrianhopebailie,
0xASK,
justmoon,
matdehaast and
sharafian
December 5, 2019 21:18
sappenin
changed the title
Interledger RFC Submission Process Proposals
Interledger RFC Submission Process (Proposals)
Dec 5, 2019
sappenin
changed the title
Interledger RFC Submission Process (Proposals)
Proposals: An improved to the Interledger RFC Submission Process
Dec 5, 2019
sappenin
changed the title
Proposals: An improved to the Interledger RFC Submission Process
"Proposals": An improvement to the Interledger RFC Submission Process
Dec 9, 2019
sharafian
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, seems more in the spirit of RFCs as Requests For Comments
matdehaast
reviewed
Dec 10, 2019
adrianhopebailie
requested changes
Dec 10, 2019
Co-Authored-By: Matthew de Haast <matt.dehaast@coil.com>
Signed-off-by: sappenin <sappenin@gmail.com>
adrianhopebailie
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matdehaast
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Interledger RFC Proposals, which are a new type of RFC document meant to improve the submission and editing process surrounding ILP RFCs.
A Proposal is a new RFC classification with minimal requirements (only style and applicability conformance) that allows contributors to have a PR committed early in the process. This allows comments and questions to be made on the proposal on a per-PR basis as opposed to having many comments/questions in a single PR that might never get merged.
For example, PR #536 had lots of community feedback (Questions, comments, suggestions) but the conversation became difficult to follow, and the specification became difficult to edit or even load.
Likewise, PR #531 had many comments, but was also neither ratified nor formally rejected, which contributes to ambiguity in the RFC process.
This PR seeks to alleviate some of these problems by introducing a new category of RFC that sits before the "Working Draft" in the current process, as well as a more formal process for rejecting an RFC.