Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): Add New fields to KYC forms #106

Merged
merged 10 commits into from
Feb 21, 2023
Merged

feat(wallet): Add New fields to KYC forms #106

merged 10 commits into from
Feb 21, 2023

Conversation

Tymmmy
Copy link
Contributor

@Tymmmy Tymmmy commented Feb 20, 2023 •
edited
Loading

Context

Changes

Added New fields for Personal Details form in KYC -> Date of Birth, Phone nr, added Create Wallett submit button
Added new fields for ID Proof form in KYC -> Selfie, also added uploaded file name under FileUpload and extra xod validations

Fixed small display issue in Menu

@Tymmmy Tymmmy linked an issue Feb 20, 2023 that may be closed by this pull request
Change KYC forms to fit Rapyd requests (FE) #105
Closed
@github-actions github-actions bot added package: wallet/frontend Wallet frontend implementations type: source Source changes labels Feb 20, 2023
@Tymmmy Tymmmy changed the title Add New fields to KYC forms feat(wallet): Add New fields to KYC forms Feb 20, 2023
@Tymmmy Tymmmy marked this pull request as ready for review February 20, 2023 17:40
raducristianpopa
raducristianpopa reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes to the validation schema, I think we should be able to get rid of the message?.toString().

packages/wallet/src/components/kyc/VerifyIdentityForm.tsx Outdated Show resolved Hide resolved
packages/wallet/src/components/kyc/VerifyIdentityForm.tsx Outdated Show resolved Hide resolved
packages/wallet/src/components/kyc/VerifyIdentityForm.tsx Outdated Show resolved Hide resolved
packages/wallet/src/ui/forms/FileUpload.tsx Outdated Show resolved Hide resolved
packages/wallet/src/components/Menu.tsx Show resolved Hide resolved
@github-actions github-actions bot added type: ci Changes to CI workflows type: documentation Improvements or additions to documentation labels Feb 21, 2023
@Tymmmy Tymmmy merged commit 465efa0 into main Feb 21, 2023
@Tymmmy Tymmmy deleted the 105-change-kyc-forms-to-fit-rapyd-requests-fe branch February 21, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
package: wallet/frontend Wallet frontend implementations type: ci Changes to CI workflows type: documentation Improvements or additions to documentation type: source Source changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change KYC forms to fit Rapyd requests (FE)
2 participants
@Tymmmy @raducristianpopa