Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close tab on declined grant #364

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

raducristianpopa
Copy link
Member

Context

Closes #363.

Changes proposed in this pull request

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jun 25, 2024
@raducristianpopa
Copy link
Member Author

raducristianpopa commented Jun 25, 2024

Extension builds preview

Name Link
Latest commit d060cc2
Latest job logs Run #9659344847
BadgeDownload
BadgeDownload

@raducristianpopa raducristianpopa marked this pull request as ready for review June 25, 2024 06:43
sidvishnoi
sidvishnoi previously approved these changes Jun 25, 2024
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a style nit. Won't block approval on that.

@sidvishnoi
Copy link
Member

And good find!

@sidvishnoi sidvishnoi merged commit 64ae7f9 into main Jun 25, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the rp/363/close-tab-on-declined-grant branch June 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tab not closing when declining the grant
2 participants