fix: show "warning" icon when disconnected #368
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: background
sidvishnoi
changed the title
Extension builds preview
|
){kind=icon}
){kind=icon}
Open
|
Will use new icons and update logic when to show each icon (similar to one in this PR, but more icons). See #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We were showing the default icon on "enabled" - which is "continuous payments enabled" earlier. I think makes more sense depending on connected state.
Changes proposed in this pull request
Show the "warning" icon if not connected. So finally:
default: if connected
warning: if not connected
green dot: continuous payment enabled, connected, and has valid link tags
red dot: continuous payment enabled, connected, but not has valid link tags