This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
feat: impl privacypass v1 with @noble/curves #3770
Draft
sublimator
wants to merge
69
commits into
main
Choose a base branch
from
nd-codeprehend-privacypass-with-noble-curves-2023-04-25
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: impl privacypass v1 with @noble/curves #3770
sublimator
wants to merge
69
commits into
main
from
nd-codeprehend-privacypass-with-noble-curves-2023-04-25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypass-with-noble-curves-2023-04-25
…ypass-with-noble-curves-2023-04-25
- Rename normalize function to normalizeB64 for clarity - Rename base64urlToBigInt to b64urlToBigInt for consistency - Optimize b64urlToBytes function by using a for loop instead of spread operator and Array.prototype.map - Update the usage of the renamed functions in blindrsa.ts
…irectory This commit moves all VOPRF-related types and functions into a new 'voprf' subdirectory within the 'crypto' directory. The purpose of this change is to better organize the code and make it easier to maintain and navigate. All import statements have been updated to reflect the new file locations.
…ypass-with-noble-curves-2023-04-25
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the old version of privacy (that implemented in privacypass/challenge-bypass-xxxx ) using @noble/curves rather than sjcl.
The original protocol