This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Unified
jest.config.cjs
: We've simplified our Jest setup by deploying onejest.config.cjs
file in each workspace. This file now treats.mts
files as ESM by adding them toextensionsToTreatAsEsm
andmoduleFileExtensions
. The configuration now also collects all workspace Jest configurations asprojects
.Removal of
jest-e2e.config.cjs
: We've deleted thejest-e2e.config.cjs
files, further streamlining the configuration process.Usage of
PROJECT_JEST
Variable: ThePROJECT_JEST
environment variable should be set in the package.json scripts in each workspace. This signals to Jest when workspace tests are run directly, rather than being collected from the monorepo root.Update in
package.json
Test Scripts: In the test scripts of the rootpackage.json
, we've set theNODE_OPTIONS
variable to--experimental-vm-modules
.Removal of
@types/jest
: We've removed@types/jest
and now import globals from@jest/globals
instead.By employing this strategy, we've streamlined the Jest configuration process for ESM support, improved the manageability of Jest setup for each workspace, and facilitated a smoother, more gradual transition from CJS to ESM.