respond with 409 when settlement engine id is dupe on new account #416 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
============================================
+ Coverage 61.71% 61.72% +<.01%
- Complexity 826 827 +1
============================================
Files 247 248 +1
Lines 4676 4690 +14
Branches 180 182 +2
============================================
+ Hits 2886 2895 +9
- Misses 1718 1722 +4
- Partials 72 73 +1
Continue to review full report at Codecov.
|
…ctor into is/respond-with-409-on-dupe-settlement Signed-off-by: Ian Simpson <ian.g.simpson@gmail.com> # Conflicts: # connector-server/src/test/java/org/interledger/connector/server/spring/controllers/admin/AccountSettingsSpringBootTest.java
nhartner
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Simpson ian.g.simpson@gmail.com