Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BTP optimistic transfer type #18

Merged
merged 2 commits into from
Dec 27, 2017
Merged

feat: add BTP optimistic transfer type #18

merged 2 commits into from
Dec 27, 2017

Conversation

sharafian
Copy link

@michielbdejong
Copy link
Contributor

I think Prepare and Fulfill together make up sendData, and the payment channel claim, which travels in the protocolData of the Response to the Fulfill, makes up sendMoney.

@sharafian
Copy link
Author

True, those are theoretically equivalent, but it seems strange to say that the first function call is made up of a Request/Response and Request, but then takes no action until a second function is called, thus releasing the final response.

I think it's more elegant to say sendData does a Request/Response containing only data (TYPE_MESSAGE), and then sendMoney does a Request/Response (TYPE_TRANSFER).

Although thinking about it it's still not perfect; the fact that there's no association to tie those two operations together is a little bit inconvenient for writing the implementation

@sharafian sharafian merged commit 0259965 into master Dec 27, 2017
@sharafian sharafian deleted the bs-btp-transfer branch December 27, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants