Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relay data field #290

Closed
wants to merge 1 commit into from
Closed

feat: relay data field #290

wants to merge 1 commit into from

Conversation

emschwartz
Copy link
Member

the connector should relay fields in the data aside from the ilp_header so that we can include other headers as well

the connector should relay fields in the data aside from the ilp_header so that we can include other headers as well
@codecov-io
Copy link

Current coverage is 84.93% (diff: 100%)

Merging #290 into master will not change coverage

@@             master       #290   diff @@
==========================================
  Files            34         34          
  Lines           969        969          
  Methods         131        131          
  Messages          0          0          
  Branches        156        156          
==========================================
  Hits            823        823          
  Misses          146        146          
  Partials          0          0          

Powered by Codecov. Last update 35012aa...871776f

Copy link
Contributor

@justmoon justmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a security concern in the future. If we ever have protocols that communicate using transfers, then this would allow anyone to spoof the connector's identity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants