Feat: add prepare/fulfill/reject #26
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 90.5% 90.81% +0.31%
==========================================
Files 3 3
Lines 316 403 +87
Branches 48 69 +21
==========================================
+ Hits 286 366 +80
- Misses 30 37 +7
Continue to review full report at Codecov.
|
| @@ -613,6 +616,138 @@ export const deserializeIlpRejection = (binary: Buffer): IlpRejection => { | |||
| } | |||
| } | |||
|
|
|||
| export interface IlpPrepare { | |||
| amount: string, | |||
| executionCondition: Buffer, | |||
There was a problem hiding this comment.
I think we should have the expires at field before the condition so the two fields that change come first
There was a problem hiding this comment.
I originally advocated for that, but executionCondition and amount are fixed length, and expiresAt might not be
|
The expiry should be fixed length too, no?
On Sat, Dec 23, 2017, 9:38 PM Ben Sharafian ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In index.ts
<#26 (comment)>
:
> @@ -613,6 +616,138 @@ export const deserializeIlpRejection = (binary: Buffer): IlpRejection => {
}
}
+export interface IlpPrepare {
+ amount: string,
+ executionCondition: Buffer,
I originally advocated for that, but executionCondition and amount are
fixed length, and expiresAt might not be
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADHIkimuzDK0UNwjbnb93qrvvCcLbKwrks5tDWTTgaJpZM4RLibv>
.
--
Evan Schwartz
Software Engineer
|
|
GeneralizedTime is a variable length octet string; it should usually be the same length (unless there are differences in time zone or milliseconds are omitted). I'm not sure how strict we are about the time zone always being |
|
Ah that's too bad. I think we should require milliseconds and the UTC timezone no matter what the encoding is |
As interledger/rfcs#361