Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ILP Reject packets instead of throwing #20

Closed
emschwartz opened this issue Feb 22, 2018 · 0 comments
Closed

Return ILP Reject packets instead of throwing #20

emschwartz opened this issue Feb 22, 2018 · 0 comments
Assignees
@sharafian

Comments

@emschwartz
Copy link
Member

The code that checks if the balance or bandwidth has been exceeded should return ILP Reject packets instead of throwing errors. Because of interledgerjs/ilp-plugin-mini-accounts#22, throwing errors will make it so no response is returned at all.

Similarly, the code that checks the fulfillment should also return ILP Reject packets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharafian sharafian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emschwartz @sharafian