Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies and switch to async/await #121

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

justmoon
Copy link
Contributor

@justmoon justmoon commented Dec 3, 2017

  • Switch to async/await
  • Turn on linting for whole codebase, not just src
  • Update eslint dependencies
  • Fix lint issues
  • Update all dependencies
  • Add customizable connect timeouts (mocha 4 no longer force exits, so the tests were hanging waiting for a 10 second connect timeout)

@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #121 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   96.08%   95.98%   -0.11%     
==========================================
  Files          12        9       -3     
  Lines         562      249     -313     
  Branches       84       25      -59     
==========================================
- Hits          540      239     -301     
+ Misses         22       10      -12
Impacted Files Coverage Δ
src/utils/details.js 97.64% <ø> (ø) ⬆️
src/utils/packet.js 90% <100%> (ø) ⬆️
src/utils/index.js 100% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562c348...2d75d06. Read the comment docs.

@@ -186,17 +185,17 @@ function * quote (plugin, {
})
}

function * quoteByPacket (plugin, packet) {
async function quoteByPacket (plugin, packet, params) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to c# 2012 haha

@justmoon justmoon mentioned this pull request Dec 18, 2017
@justmoon justmoon merged commit 9bfbde3 into master Dec 20, 2017
@justmoon justmoon deleted the chore/st-updates branch December 20, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants