New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ID for checking unique components. Name can be repetitive #7

Merged

riteshnoronha merged 1 commit into main from fix/uniq-checks

Feb 2, 2023

Contributor

riteshnoronha commented Feb 1, 2023

An sbom name is not required to be unique across components in the same file. We should use ID i.e bom-ref for cdx and spdxidentifier for spdx.

{
  "bom-ref": "pkg:dotnet/xunit.runner.visualstudio@2.4.3?package-id=a43b99563e30504f",
  "name": "xunit.runner.visualstudio"
}
{
  "bom-ref": "pkg:dotnet/xunit.runner.visualstudio@2.4.3?package-id=6a020a55c4a049fa",
  "name": "xunit.runner.visualstudio"
}
{
  "bom-ref": "pkg:dotnet/xunit.runner.visualstudio@2.4.3?package-id=f9fe01e7b5f92d4e",
  "name": "xunit.runner.visualstudio"
}


          Use ID for checking unique components. Name can be repetitive

a2dea0c

riteshnoronha requested review from surendrapathak and kchetans

February 1, 2023 23:26

surendrapathak approved these changes

View reviewed changes

Collaborator

surendrapathak left a comment

LGTM

riteshnoronha merged commit 6c8c1e7 into main

surendrapathak deleted the fix/uniq-checks branch

July 10, 2023 06:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment