Write new tests from scratch that query using im.js

[dmahajan980]

Description

Currently the tests fail due to the fact that HumanMine is HTTPS and we have issues with CORS

Steps to Reproduce

Run npm test

Expected Behaviour

All tests should pass.

Actual Behaviour

All the tests fail.

Settings

• OS: Ubuntu 18.04 LTS

Screenshots

[lazycipher]

@dmahajan980, I believe trying to solve CORS first will be better at first. If not then you can try to move the tests to http mines! What do you say @AdrianBZG?

[dmahajan980]

@lazycipher currently @Zemotacqy is solving the CORS issue. But I guess it would be better to make the tests functional till the time CORS isn't fixed. Maybe we can move back to HumanMine later once the CORS is fixed.

[lazycipher]

@dmahajan980, He started working on that 13 days ago. I guess it'll be better to ask for an update and then we may proceed if he'll be needing more time!

[AdrianBZG]

I think that fixing the CORS issue is a high priority at the moment. I don't know if Zemotacqy has actually made any progress, but worth just trying to solve it instead of waiting.

[AdrianBZG]

The CORS issue was fixed in #33 by removing the Express middle layer and using directly im.js, so we can now re-write the tests using im.js queries.

[nocodes]

Hi @AdrianBZG , I’m an outreachy applicant and I would like to take up this issue

[PrastutiUpadhaya]

Hi, Can I try this out?

[codeEmpress1]

Hi, I'm an outreachy applicant and I will like to work on this issue.

[Joyce-O]

I created a pull request with hopefully a solution to the issue, however I don't think my solution maybe what is expected and I will like to get a feedback. @AdrianBZG
#77

[priscacodes]

Hi @dmahajan980 I am an Outreachy applicant and I will like to pick this up. I have got some experience with unit and integration testing in Nodejs.

[AdrianBZG]

Hi, @Joyce-O added a test using im.js that makes the 'npm test' work now, but we would like to have a larger list of tests that checks that (almost) every query used by the app is tested in the tests.

Happy if anyone wants to pick this up.

[muskangupta-iitr]

Hi @AdrianBZG, I am Outreachy aspirant and want to take the task for writing the tests. I want to discuss that when I am trying to fetch json data from https://www.humanmine.org/humanmine/service with im.js and getting still getting the protocol error. In Pull request #77, the url is changed from https://www.humanmine.org/humanmine/service to http://zebrafishmine.org/service which is http url. That's why npm test is working. I think im.js doesn't support the https protocol. Correct me if I am wrong ?

[Joyce-O]

Hi, @Joyce-O added a test using im.js that makes the 'npm test' work now, but we would like to have a larger list of tests that checks that (almost) every query used by the app is tested in the tests.

Happy if anyone wants to pick this up.

Alright, I will update it then.