Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scroll up Button #90

Open
Emuohwo opened this issue Mar 17, 2020 · 4 comments
Open

Add Scroll up Button #90

Emuohwo opened this issue Mar 17, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed very easy

Comments

@Emuohwo
Copy link

Emuohwo commented Mar 17, 2020

Description

Scrolling up a web page is easier when the is a button that does the job. It is common in most websites. The need for this button is obvious when the web page is resized.

Steps to Reproduce

Add the html code in footer.pug
Style it in data-browser-style-main.css and
Add the scroll function in main-view.js
@Nikhil-Vats @AdrianBZG @yochannah Please assign the issue to me.

Expected Behaviour

This button should take a user to the top of the page when it is clicked. Also, This button will appear will the user has scrolled down to a certain height

Actual Behaviour

The button is missing on the page.

Settings

  • OS: Window 7

Screenshots

image

@AdrianBZG AdrianBZG added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed very easy labels Mar 17, 2020
@PrastutiUpadhaya
Copy link

@AdrianBZG Can i work on this?

@AdrianBZG
Copy link
Member

@PrastutiUpadhaya Sure, go ahead.

@Emuohwo
Copy link
Author

Emuohwo commented Mar 18, 2020

@AdrianBZG I've already worked on this issue on my repository and was about to create a pull request for it. I was about to copy the issue number in order to do that only to find out that you've assigned it to @PrastutiUpadhaya. What do you suggest i should do?

@PrastutiUpadhaya
Copy link

@AdrianBZG I've already worked on this issue on my repository and was about to create a pull request for it. I was about to copy the issue number in order to do that only to find out that you've assigned it to @PrastutiUpadhaya. What do you suggest i should do?

Hey @Emuohwo it's alright, send the pull request, I had anyway just started working so it's cool I will work on some other issue :)

AdrianBZG pushed a commit that referenced this issue Sep 3, 2020
The classes select menu did not filter when queried, and would did not
update when the mine was changed. This commit fixes this by indexing
the available classes on first render and each time the mine changes.

Closes: #89

Squashed commits:
Change available classes when the mine changes
Rebuild search index when the mine changes
Reset the query when the popup closes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed very easy
Projects
None yet
Development

No branches or pull requests

3 participants