Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFF3: Should we be case-sensitive #20

Closed
julie-sullivan opened this issue Jul 18, 2019 · 2 comments
Closed

GFF3: Should we be case-sensitive #20

julie-sullivan opened this issue Jul 18, 2019 · 2 comments

Comments

@julie-sullivan
Copy link
Member

So I checked both so.obo and so-simple.obo and turns out both files do not have an exact match of 'DNaseI_hypersensitive_site' and 'recombination_region' but
1. for type 'DNaseI_hypersensitive_site' -> 'so.obo' and 'so-simple.obo' do have 'DNAseI_hypersensitive_site' here the case of third letter is difference, its capital 'A'.
2. for type 'recombination_region' -> 'so.obo' and 'so-simple.obo' have 'mitotic_recombination_region', 'non_allelic_homologous_recombination_region', etc. 

See intermine/intermine#1828 for details.

This problem has been fixed but there are older files that have the incorrect spelling.

@rachellyne since this is the NCBI only I think we should be case sensitive and this file should fail. What do you think?

@rachellyne
Copy link
Member

Yes, I agree.

@julie-sullivan
Copy link
Member Author

this fails as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants