Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regionsearch label alignment not always correct #29

Closed
yochannah opened this issue Jan 10, 2017 · 6 comments
Closed

Regionsearch label alignment not always correct #29

yochannah opened this issue Jan 10, 2017 · 6 comments

Comments

@yochannah
Copy link
Member

examples:

image

image

@yochannah yochannah added the bug label Jan 10, 2017
@yochannah
Copy link
Member Author

I think this happens when the features don't overlap the original regions on both sides.

@yochannah
Copy link
Member Author

yochannah commented Jan 18, 2017

Correcting the min-max stops the labels overflowing, but it becomes clear that the math is out somewhere for these.

For flymine's third defaut region there should be three chunks of different overlapping features. The features marked below in yellow and purple overlap almost perfectly, as do the blue and green, hence why there are 5 overlaps in total but only three separate chunks should be seen on the diagram, assuming I've done my math correctly. (Please yell at me if I haven't).This is not to scale, I did it in a paint program, and the regions should all be about the same length

image

We also need to remove or reduce the blur, but this doesn't fully fix the problem. Short term: I'm removing the graphs from the display.

Longer term: make sure the clculations are fully tested, esp. for boundaries and scenarios where there aren't overlaps on both sides of the region.

@yochannah
Copy link
Member Author

ok, removing blur and allowing the min-start and max-end values to be part of the original set has made things better, but I don't think that the left two should overlap :/

image

yochannah added a commit to yochannah/bluegenes that referenced this issue Jan 18, 2017
…the specified region. Partly helps with intermine#29 but doesn't resolve the issue completely, so we've hidden the distribution graph for now since it's not really a minimal feature
@yochannah yochannah added enhancement and removed bug labels Jan 18, 2017
@sehgalvibhor
Copy link
Contributor

@yochannah : How can I replicate this on the dev environment?

@yochannah
Copy link
Member Author

@sehgalvibhor Good question! I had to dig a little to remember (note to self: always include file locations when you make tickets!)

Uncomment this line: https://github.com/intermine/bluegenes/blob/dev/src/cljs/bluegenes/pages/regions/results.cljs#L82 that should do it!

P.S. sorry for the slow reply, I"ve been out of the office travelling! :)

@yochannah
Copy link
Member Author

this issue is no longer valid - we removed the graph since it wasn't valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General work
  
Done
Development

No branches or pull requests

2 participants