-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regionsearch label alignment not always correct #29
Comments
I think this happens when the features don't overlap the original regions on both sides. |
Correcting the min-max stops the labels overflowing, but it becomes clear that the math is out somewhere for these. For flymine's third defaut region there should be three chunks of different overlapping features. The features marked below in yellow and purple overlap almost perfectly, as do the blue and green, hence why there are 5 overlaps in total but only three separate chunks should be seen on the diagram, assuming I've done my math correctly. (Please yell at me if I haven't).This is not to scale, I did it in a paint program, and the regions should all be about the same length We also need to remove or reduce the blur, but this doesn't fully fix the problem. Short term: I'm removing the graphs from the display. Longer term: make sure the clculations are fully tested, esp. for boundaries and scenarios where there aren't overlaps on both sides of the region. |
…the specified region. Partly helps with intermine#29 but doesn't resolve the issue completely, so we've hidden the distribution graph for now since it's not really a minimal feature
@yochannah : How can I replicate this on the dev environment? |
@sehgalvibhor Good question! I had to dig a little to remember (note to self: always include file locations when you make tickets!) Uncomment this line: https://github.com/intermine/bluegenes/blob/dev/src/cljs/bluegenes/pages/regions/results.cljs#L82 that should do it! P.S. sorry for the slow reply, I"ve been out of the office travelling! :) |
this issue is no longer valid - we removed the graph since it wasn't valid |
examples:
The text was updated successfully, but these errors were encountered: