-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inline styles #456
base: dev
Are you sure you want to change the base?
Remove inline styles #456
Changes from 5 commits
1e6e612
3adbdd7
19806c8
e516ede
367388a
65a0b3b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -174,6 +174,10 @@ | |
|
||
div.value {} | ||
} | ||
|
||
.col-xs-2{ | ||
white-space: nowrap; | ||
} | ||
} | ||
|
||
.popover-content { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,15 @@ | |
.icon-2x { | ||
.icon(2em) | ||
} | ||
|
||
|
||
#icons { | ||
position :absolute; | ||
width :0; | ||
height :0; | ||
} | ||
|
||
|
||
.icon.icon-globe{ | ||
fill: #939393; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -118,6 +118,10 @@ | |
.allresults { | ||
display: flex; | ||
flex-direction: column; | ||
.feature { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excellent, this is what I want to see more of [= |
||
overflow-wrap: break-word; | ||
} | ||
|
||
} | ||
|
||
.results { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,6 +96,7 @@ | |
.im-table-toolbar label { | ||
.dark-text; | ||
} | ||
|
||
} | ||
|
||
.results-and-enrichment { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -140,3 +140,8 @@ input.form-control:focus { | |
label { | ||
color: @body-foreground-color; | ||
} | ||
|
||
.col-xs-3{ | ||
font-size :0.8em; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -291,7 +291,8 @@ label { | |
overflow: visible; | ||
margin-left: calc(100vw - 100%); | ||
margin-right: 0; | ||
} | ||
} | ||
|
||
|
||
.loading { | ||
display: flex; | ||
|
@@ -353,6 +354,12 @@ button.btn, button.cta { | |
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think many of these selectors added to Each "component" generally have their own less source file. In the case of Could you go through the selectors you added to |
||
.btn.btn-raised.dropdown-toggle | ||
{ | ||
text-transform: none; | ||
white-space: normal; | ||
} | ||
|
||
.dropdown-mixed-content { | ||
//mixin used for list / lookup/ = / > / < lookup dropdown | ||
//(probably other places too) | ||
|
@@ -399,13 +406,28 @@ button.btn, button.cta { | |
} | ||
} | ||
|
||
.container-fluid.results{ | ||
width: 100%; | ||
} | ||
|
||
.icon.icon-document-list { | ||
margin-left: 0px;} | ||
|
||
.relative.im-table{ | ||
background-color: white; | ||
} | ||
.no-gutter { | ||
margin-right: 0; | ||
margin-left: 0; | ||
} | ||
|
||
.description-div{ | ||
background-color: #D2CEBF; | ||
padding: 10px; | ||
overflow: auto; | ||
} | ||
|
||
|
||
.no-gutter > [class*="col-"] { | ||
padding-right: 5px; | ||
padding-left: 5px; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,7 @@ | |
.icon { | ||
color: @cta-color-text; | ||
fill: @cta-color-text; | ||
position: absolute; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to break the positioning of icons for some buttons elsewhere. |
||
} | ||
} | ||
|
||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,8 +38,7 @@ | |
[:span.markup markup] | ||
[:span.controls | ||
[:button.btn.btn-default.btn-xs.btn-raised | ||
{:on-click (fn [] (dispatch [:messages/remove id])) | ||
:style {:margin 0}} "X"]]])})) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't see that |
||
{:on-click (fn [] (dispatch [:messages/remove id]))} "X"]]])})) | ||
|
||
(defn messages | ||
"Creates a message bar on the bottom of the screen" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,8 +46,7 @@ | |
(not (contains? registry current-mine)) | ||
{:db (assoc db-with-registry :current-mine :default) | ||
:dispatch [:messages/add | ||
{:markup [:span (str "Your mine has been changed to the default as your selected mine '" (name current-mine) "' was not present in the registry.")] | ||
:style "warning"}]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you revert this change? It's by chance called |
||
{:markup [:span (str "Your mine has been changed to the default as your selected mine '" (name current-mine) "' was not present in the registry.")]}]} | ||
;; Fill in the mine details if it's missing. | ||
;; (This happens when we use a registry mine.) | ||
(nil? (get-in db-with-registry [:mines current-mine])) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.qb-label
is also used for query builder attributes, where we don't want the margin-left (seesrc/cljs/bluegenes/pages/querybuilder/views.cljs:83
).Maybe split it into
.qb-attribute-label
where the margin-left is the only difference, changing the attributes to use this class instead?