Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subclasses #568

Merged
merged 24 commits into from
Oct 7, 2020
Merged

Support subclasses #568

merged 24 commits into from
Oct 7, 2020

Commits on Aug 19, 2020

  1. Configuration menu
    Copy the full SHA
    8d4c82a View commit details
    Browse the repository at this point in the history
  2. QB: Fix constraining to a subclass

    Fixes intermine#508. There were three main problems:
    - subclass was added to any child class of the class (e.g. ThreePrimeUTR
    type constraint was added to Gene.UTRs.organism in addition to Gene.UTRs)
    - only direct subclasses were selectable, not indirect (descendants)
    - it was possible to create a subclass constraint to the original class
    (e.g. type constraint for Gene.UTRs to be UTR, which it already is)
    heralden committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    093ac8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa84adf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d3a376d View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. QB: Make subclass constraining much more robust

    - When expanding query tree to a constrainted subclass, dropdown will
      show correct value
    - Changing subclass will change it in query editor (when present) and
      fetch preview
    - Fix various incorrect docstrings
    - Fix bug creating multiple identical subclass constraints causing
      invalid query error
    - Remove stale subclasses (resulting in empty class in query editor)
      when removing last view of a class
    - Do not allow setting subclass constraint to the class itself (i.e. not
      a subclass)
    heralden committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    1beae43 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Configuration menu
    Copy the full SHA
    a61dcf8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9425c40 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Configuration menu
    Copy the full SHA
    2f8b3d8 View commit details
    Browse the repository at this point in the history
  2. QB: Parse type-constraints from qb:menu for model-browser

    Since you're able to set subclasses and drill down, without adding it to
    :im-query.  Not sure if there's even done a full-path lookup in the
    tree, but it's still good practice to make sure the model supports it.
    heralden committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    0d67b03 View commit details
    Browse the repository at this point in the history
  3. Do not remove empty classes from model

    This led to a crash in the query builder caused by setting a subclass
    which was empty. The model should be kept complete, and trimming should
    be done in the UI.
    heralden committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d6affdd View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Configuration menu
    Copy the full SHA
    4eaf4fc View commit details
    Browse the repository at this point in the history
  2. QB: Fix subclass constraint not getting added for descendant attribute

    Now we make sure to add all parent subclasses for an attribute.
    heralden committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    cf91723 View commit details
    Browse the repository at this point in the history
  3. QB: Make subclass constraints even more robust

    - Clear subclass descendants from :enhance-query
    - Clear subclass descendant views from :order
    - Add parent subclasses when summarizing view
    heralden committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    971e7b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. QB: Fix various bugs related to subclasses

    - Couldn't summarize unique class descendant of non-added subclass
      (Flymine e.g. Gene -> Child Features [Binding Site] -> Factor)
    - With im-path/walk fixes, subclass constraints changed contents of
      subclass dropdown (selecting dropdown item changed the dropdown)
    - With im-path/walk fixes, constrained subclass was displayed in
      parentheses instead of superclass
    - Class unique to parent subclass displayed a blank name in Query Editor
      (Flymine e.g. Gene -> Child Features [Binding Site] -> Factor)
    heralden committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3c30706 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. QB: Improve usability of model browser button group

    Fixes intermine#550. I decided to keep the Summarise button, but add icons,
    tooltips and better names.
    heralden committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    52e88ce View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Configuration menu
    Copy the full SHA
    9cb3a96 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Make tools active for subclasses of a supported class

    For this to work properly, tools that wish to support subclasses will
    have to make sure their query sets `from` to `imEntity.X.class`.
    heralden committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    e910fb9 View commit details
    Browse the repository at this point in the history
  2. Autoformat code

    heralden committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    b95b76d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    960134a View commit details
    Browse the repository at this point in the history
  4. Re-enable templates-for-entity in report page

    It used to crash due to lacking subclass support.
    heralden committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    6ea57ea View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    501ed6a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d6f0cfe View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Configuration menu
    Copy the full SHA
    e020907 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a9f3326 View commit details
    Browse the repository at this point in the history