Support subclasses by passing type-constraints with model #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two alternatives to passing type-constraints to `walk` so that all functions would work with subclass constraints: - Pass as optional argument, which would need to be added to every function dependent (directly or indirectly) on `walk` - Pass assoc'ed to model The latter approach was chosen as it would require much less refactoring in Bluegenes, the downside being it's more subtle. Hopefully mentioning this in every docstring will be enough.
…subclass This function was also in dire need of proper documentation.
This is invalid according to the PathQuery API, as type constraints can't participate in constraint logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two alternatives to passing type-constraints to
imcljs.path/walkso that all functions would work with subclass constraints:walkThe latter approach was chosen as it would require much less refactoring in Bluegenes, the downside being it's more subtle. Hopefully mentioning this in every docstring will be enough.
Resolves #50 by making the docstring clearer.
I will wait with merging this until I have the Bluegenes PR utilizing this ready.