Make deconstruct-by-class match im-tables behaviour #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how the view is overwritten by a single target class as required by tolist WS, this leads to a differing query result set, due to views implicitly constraining refs/colls to be present (as inner join is the default). To match this behaviour without views, we need to add IS NOT NULL constraints for them, except in the case where the class is an outer join, when it should not receive a substitute constraint.
We want to do this as it's arguably the expected behaviour of these functions. It would also mean fixing a predicted problem causing more objects than intended to be passed on to BG visualizations.
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how the view is overwritten by a single target class as required
by tolist WS, this leads to a differing query result set, as the views
implicitly constrain refs/colls to be present (inner join being the
default). To match this behaviour without views, we need to add IS NOT
NULL constraints for them, except in the case where the class is an
outer join, when it should not receive a substitute constraint.
This bug was found investigating intermine/im-tables-3#129 where saving a list in im-tables-3 would lead to a different amount of items compared to im-tables (legacy webapp).