-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support selection from multiple lists #32
Comments
Hi @AdrianBZG, I'm an Outreachy applicant and would love a shot at this issue. |
Hi @JM-Mendez , Great! Let me know if you have any questions, I'll assign this to you 😄 |
Awesome! I'll start getting familiar with the codebase and the linked issues to better understand the requirements, and then get back to you. Are you the mentor for this issue/project that I need to report to? Not sure how this process works. |
That sounds like a good way to start. Yes I'm the mentor for this project, so happy to help with any issues. |
So I came across 2 issues so far with setting up the project. I'm not familiar with coffeescript, so I just traced my way through the compiled node modules package.
I was able to
in the https module of imjs. I'm not sure why it wasn't propagated up the promise chain. But changing the protocol to Yet, the test still hanged. I was only able to trace it as far as the service module authorise method. I'm not entirely sure, but it looks like EDIT: Just found this existing issue, so I will disregard this concern.
I doubt these 2 issues would prevent me from troubleshooting the main issue. Although without webpack or a gulp watch task, I'd have to restart the project on each change. Would you like me to at the very least open an issue to address issue 2? I have experience setting up a dev environment using webpack and gulp, so can do it either way. |
@JM-Mendez It would be very nice if you could set-up the dev environment, and this issue was opened to try to address that: #67. Happy if you give it a try 😄 After that we can take a look at what happens with the other issue. |
EDIT: Crossposted to Draft PR #82 so that I can keep track of my contributions for Outreachy. Hi @AdrianBZG, I've managed to add multiple lists to the query using I stepped through the debugger and for the most part it returns a result from the server, until it tries to parse the xml. Then I run into the error below. I truncated the "Error: XML is not well formatted. Got
<query model="genomic" view="Gene.symbol Gene.name..." constraintLogic="(A OR B..." >
<constraint path="Gene" op="IN" value="PL_BHF_UCL_cardiovascGenes" code="N" />
<constraint path="Gene" op="IN" value="PL_DiabesityGWAS_pval-4" code="N" />
</query> Yet when I try running the query on the humanMine website, I get this xml structure: <query model="genomic" view="Gene.name Gene.symbol..." constraintLogic="A and B">
<constraint path="Gene" op="IN" value="PL_BHF_UCL_cardiovascGenes" code="B" />
<constraint path="Gene" op="IN" value="PL_DiabesityGWAS_pval-4" code="A"/>
</query> This seems well formatted to me, so I'm at a loss as to what the error means. The stack trace throws inside the I have no idea where to go from here. Any thoughts? |
Hi @JM-Mendez , In this query:
You see that in the two constraints, you have the same code (N). Can you try to change that to A for the first one and B for the second one and see if the query works? If I remember correctly, it's required to add an unique code to each constraints (A,B,C,D,E...). PS: Let's discuss that in your draft PR. |
* Place pie and bar chart in DataViz dir * Move Table component to DataViz dir * Move Charts and Table section to DataViz module * Colocate FormGroups component where it's used
Currently the user can specify only one list from which he or she can view Genes/Proteins etc. The aim of this issue is to enable a user to select from more than one list at a time (much like using "ONE OF" operator).
Here are the caveats:
imjs
query interface supports adding only one of the list at a time.constraintLogic
(likeA or B
where A and B denote the individual list constraints). Butimjs
query at the moment does not support changing the constraintLogic once it is set. See issue add setConstraintLogic() public method imjs#18For a more verbose description, refer to the discussion on PR List constraint logic #31
The text was updated successfully, but these errors were encountered: