Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licence dataset display null #2161

Closed
danielabutano opened this issue Dec 6, 2019 · 3 comments
Closed

Licence dataset display null #2161

danielabutano opened this issue Dec 6, 2019 · 3 comments
Assignees
@danielabutano
Labels
fair please-test
Milestone
InterMine 4.1.2

Comments

@danielabutano
Copy link
Member

danielabutano commented Dec 6, 2019 •
edited

After some investigations, I have discovered the only the gff3 bio datasources are effected by this issue.
If you do not set the licence in the project.xml, the string null is stored in the database and the webapp will display the string null in the query result or report page
image
@danielabutano danielabutano self-assigned this Dec 6, 2019
danielabutano pushed a commit to danielabutano/intermine that referenced this issue Dec 6, 2019
Updated the GFF3 converts so if the licence is not set -> webapp does…
79f36e3 
…n't display the string null. see intermine#2161
@danielabutano danielabutano added this to the InterMine 4.1.2 milestone Dec 11, 2019
@danielabutano danielabutano added this to InterMine 4.1.2 (January 2019) in Roadmap & release planning Dec 11, 2019
@danielabutano
Copy link
Member Author

The fix above prevents to save the string null in the db. If we do not rebuild the db, we need a fix the frontend side.
Also the report.jsp page need the check
field.value != 'null'

danielabutano pushed a commit to danielabutano/intermine that referenced this issue Jan 8, 2020
do not display licence null in the reposrt page. see intermine#2161
b4dae6d
@danielabutano danielabutano mentioned this issue Jan 8, 2020
Closed
@danielabutano
Copy link
Member Author

For the list result, see the ticket

@danielabutano danielabutano mentioned this issue Jan 8, 2020
Merged
7 tasks
@danielabutano
Copy link
Member Author

Report page for protein is broken - partially displayed
image
Need to check if the field is a string!

danielabutano pushed a commit to danielabutano/intermine that referenced this issue Jan 16, 2020
fix broken report page for protein see intermine#2161
b9d6bf1
danielabutano pushed a commit that referenced this issue Jan 16, 2020
Merge pull request #2181 from danielabutano/dev
5a48996 
fix broken report page for protein see #2161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielabutano danielabutano

Labels
fair please-test
Projects
None yet
Milestone
InterMine 4.1.2
Development

No branches or pull requests
1 participant
@danielabutano