Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAR ThaleMine - 2 #2118

Merged

Conversation

asherpasha
Copy link
Contributor

@asherpasha asherpasha commented Oct 1, 2019

Details

Currently in ThaleMine's 4.0.1 build CDS sequences are not loading. We think that the problem is in this configuration file:

Old Araport ThaleMine had the following configuration:

3702.excludes=CDS,protein
3702.attributes.symbol=symbol
3702.attributes.Alias=synonym
3702.attributes.Note=briefDescription
3702.attributes.computational_description=computationalDescription
3702.attributes.curator_summary=curatorSummary
3702.mRNA.attributes.conf_class=confidenceClass
3702.mRNA.attributes.conf_rating=confidenceRating
3702.transposable_element_insertion_site.attributes.polymorphism_site=polymorphismSite

But the current dev version of Intermine only has three lines from it. I suggest instead of using Araport old configuration in intermine repository, we use the same configuration in thalemine-bio-sources repository in GFF3 loader. Then we would have more control over the configuration.

Thoughts?

Testing

Travis Testing.

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • Checkstyle

@sergiocontrino
Copy link
Member

good idea.

@danielabutano danielabutano mentioned this pull request Oct 22, 2019
@sergiocontrino sergiocontrino changed the base branch from dev to release-candidate October 22, 2019 14:05
@sergiocontrino sergiocontrino merged commit 9ca5999 into intermine:release-candidate Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants