Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThaleMine Updates to psi BioSource #2151

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

asherpasha
Copy link
Contributor

@asherpasha asherpasha commented Nov 17, 2019

Details

This pull request updates psi BioSource to include ThaleMine support. Please review the changes. Note: These changes are very similar the Araport ThaleMine psi source.

Testing

The changes are tested using the current live and dev versions of ThaleMine at the Bio-Analytic Resource.

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • Checkstyle

@asherpasha
Copy link
Contributor Author

I think Travis build failed because this link did not work:

https://www.ebi.ac.uk/intact/maven/nexus/content/repositories/ebi-repo/psidev/psi/mi/jami/jami-interactionviewer-json/2.0.2/jami-interactionviewer-json-2.0.2.jar

I need to run Travis build after this link is working.

@sergiocontrino sergiocontrino self-assigned this Jan 10, 2020
@sergiocontrino
Copy link
Member

sergiocontrino commented Jan 14, 2020

i think all is fine. did a small build and webapp with an updated dev repo as test. merging. if still travis problems, i'll fix them.

@sergiocontrino sergiocontrino merged commit c10ed6a into intermine:dev Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants