Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebservicePythonCodeGenerator.java #2172

Closed
wants to merge 3 commits into from
Closed

Conversation

nuin
Copy link
Contributor

@nuin nuin commented Dec 27, 2019

According to Python's code styling PEP8 there shouldn't be unexpected spaces around keyword / parameter equals

Details

Check Python's PEP 8 and unexpected spaces around keyword / parameter equals

Testing

Python code generated from the queries should have

code="A"

instead of

code = "A"

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • [ x] Checkstyle

According to Python's code styling PEP8 there shouldn't be  `unexpected spaces around keyword / parameter equals`
@danielabutano danielabutano self-requested a review January 9, 2020 11:13
@danielabutano
Copy link
Member

danielabutano commented Jan 9, 2020

Hi @nuin. Thank you for the PR!
Could you please update also the *.python.expected files (shown in the screenshot below) in order to fix the 19 failing tests and having Travis happy again? :)
image

@nuin
Copy link
Contributor Author

nuin commented Jan 9, 2020

Hi

I modified all files with code = "A/B/C" in the intermine/api/src/test/resources/org/intermine/api/query/codegen directory, don't know if there are more.

@danielabutano
Copy link
Member

danielabutano commented Jan 10, 2020

Thanks @nuin.
Unfortunately you have added, by mistake, an empty line after the line
from intermine.webservice import Service
in every file you have updated and you added a space on the line row["organism.shortName"]) in some of those files, letting Travis failing on 20 tests :(
When you commit in your branch, you can have a look at Travis Details in this PR to see if there are still some tests failing.
thank you!!!!

@nuin
Copy link
Contributor Author

nuin commented Jan 10, 2020

@danielabutano My IDE has some automatic linting that "fixes" styles based on PEP8 standards. I will see what I can do.

danielabutano pushed a commit to danielabutano/intermine that referenced this pull request Jan 13, 2020
@danielabutano
Copy link
Member

danielabutano commented Jan 15, 2020

I have fixed the remaining failing tests and created a new PR #2179.
I close this PR and merge the other. Thanks for the contributions @nuin!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants